]> cloud.milkyroute.net Git - dolphin.git/commit
Remove main.cpp from dolphinstatic_SRCS
authorAlexander Miller <alex.miller@gmx.de>
Fri, 18 May 2018 20:43:25 +0000 (22:43 +0200)
committerAndreas Sturmlechner <asturm@gentoo.org>
Fri, 18 May 2018 20:43:58 +0000 (22:43 +0200)
commitb607091c3982f6b84732fcf0c23c1c3f0054f203
treeb2b61646964ab7dd05866a0e902df882aaa2c3d8
parent9a3d4a29ba94ff6c1a506ad2b186ee19cdc574b5
Remove main.cpp from dolphinstatic_SRCS

Summary:
The file main.cpp is already in dolphin_SRCS and doesn't
belong in dolphinstatic_SRCS.

Normally the duplicate object is simply ignored, but with
link time optimization (LTO), linking dolphin can fail.
Apparently, the compiler tries to inline inline kdemain()
in this case. That is undesirable anyway and it ultimately
fails because the DBusInterface definition is not available:

.../ccHEv6cl.ltrans0.ltrans.o: In function `DBusInterface::~DBusInterface()':
<artificial>:(.text+0x2583): undefined reference to `vtable for DBusInterface'
.../ccHEv6cl.ltrans0.ltrans.o: In function `DBusInterface::~DBusInterface()':
<artificial>:(.text+0x5aa3): undefined reference to `vtable for DBusInterface'
.../ccHEv6cl.ltrans0.ltrans.o: In function `kdemain':
<artificial>:(.text+0x7686): undefined reference to `DBusInterface::DBusInterface()'
<artificial>:(.text+0x7b64): undefined reference to `vtable for DBusInterface'
collect2: error: ld returned 1 exit status

See also <https://bugs.gentoo.org/655710>.

Reviewers: #dolphin, elvisangelaccio

Reviewed By: elvisangelaccio

Subscribers: elvisangelaccio, asturmlechner, kfm-devel

Tags: #dolphin

Differential Revision: https://phabricator.kde.org/D12929
src/CMakeLists.txt