]> cloud.milkyroute.net Git - dolphin.git/commit
After opening and switching to a new tab, always focus the view
authorNate Graham <nate@kde.org>
Tue, 29 Jan 2019 13:31:46 +0000 (06:31 -0700)
committerNate Graham <nate@kde.org>
Tue, 29 Jan 2019 13:33:27 +0000 (06:33 -0700)
commitb7ceb51b44da394089689a2649cc8529c1f74669
tree4b1ff0b0987f3634e8a411f53b21ad9740b6639a
parent8bc93b564c283a677e02dc2ac71b40b63a990e38
After opening and switching to a new tab, always focus the view

Summary:
When Dolphin opens a new tab and immediately switches to it, the URL navigator gets focus if it's editable. If it's not, the breadcrumbs bar gets keyboard focus, which is not very useful since it's not really intended for keyboard navigation.

This patch changes that behavior so that the view always gets focus, which seems more useful and more consistent.

BUG: 401899
FIXED-IN: 19.04.0

Test Plan:
1. Put the URL navigator into breadcrumbs mode
2. Open a new tab
3. Observe that the view gets keyboard focus
4. Put the URL navigator into editable mode
5. Open a new tab
6. Observe that the view still gets keyboard focus

Reviewers: #dolphin, elvisangelaccio

Reviewed By: #dolphin, elvisangelaccio

Subscribers: emateli, elvisangelaccio, kfm-devel

Tags: #dolphin

Differential Revision: https://phabricator.kde.org/D17635
src/dolphintabwidget.cpp