]> cloud.milkyroute.net Git - dolphin.git/commit
Add "What's This?" to nearly everything in the main window
authorFelix Ernst <fe.a.ernst@gmail.com>
Sun, 23 Jun 2019 19:19:49 +0000 (21:19 +0200)
committerElvis Angelaccio <elvis.angelaccio@kde.org>
Sun, 23 Jun 2019 19:19:49 +0000 (21:19 +0200)
commitbd788a3ff425992b87a5c5b86abc6c324a73784a
tree3bbf0b8177c6b63330d523ed39e7534ff1b9bc50
parente6c1b97d67f6b6c6d4ad935db14241b041b3fca4
Add "What's This?" to nearly everything in the main window

Summary:
This commit adds "What's This?" help to nearly everything in the
Dolphin main window (panels, views, buttons, ...). It adds the "?"
to the title bar so this help can easily be called.

For links in those help texts to work the WhatsThisClickedEvents are
handled in the main window class. This doesn't work for menus because
events from them aren't forwarded to the main window for some
reason so EventFilters are installed for the Control button menus.

Modifying the "Help" menu of KXmlGui is deprecated so no EventFilter
can be installed in the menubar. Therefore help texts without links
are provided for the menubar.

Test Plan:
Check if the event handling might make any problems.
Check for any big mistakes in the help messages.

Reviewers: #dolphin, elvisangelaccio

Subscribers: broulik, elvisangelaccio, yurchor, kfm-devel

Tags: #dolphin

Differential Revision: https://phabricator.kde.org/D20471
src/dolphinmainwindow.cpp
src/dolphinmainwindow.h
src/dolphinviewcontainer.cpp
src/statusbar/dolphinstatusbar.cpp
src/views/dolphinviewactionhandler.cpp
src/views/dolphinviewactionhandler.h