]> cloud.milkyroute.net Git - dolphin.git/commit
Fix crash when closing split view with ownCloud plugin loaded
authorMartin T. H. Sandsmark <martin.sandsmark@kde.org>
Sun, 15 May 2016 16:09:09 +0000 (18:09 +0200)
committerMartin T. H. Sandsmark <martin.sandsmark@kde.org>
Sat, 21 May 2016 16:16:41 +0000 (18:16 +0200)
commitbed16191b5e9253d8658c0dac0d336b3dab5e0e3
tree44f576fb37fe37b9b314244d021b881ced0efcab
parent3b95644fa1495785f617165f4e8035528ec714e8
Fix crash when closing split view with ownCloud plugin loaded

KPluginLoader::instantiatePlugins() wraps QPluginLoader::instace(),
which doesn't return a new object for each call, so if we set the
KFileItemModelRolesUpdater instance as parent to the plugin the shared
instance will be deleted leading to crashes when other instances of
KFileItemModelRolesUpdater tries to use their plugin objects.

To fix this, set the QApplication as a parent.

BUG: 357479

REVIEW: 127930
src/kitemviews/kfileitemmodelrolesupdater.cpp