]> cloud.milkyroute.net Git - dolphin.git/commit
Fix crash during shutdown
authorDavid Hallas <david@davidhallas.dk>
Sat, 16 Feb 2019 15:50:42 +0000 (16:50 +0100)
committerDavid Hallas <david@davidhallas.dk>
Mon, 18 Feb 2019 07:58:11 +0000 (08:58 +0100)
commitc72fdaa77380ef811dfef626a4edadbb824ed252
tree8ad301a9cc9cb250d0a10a652fc1faece33eda5b
parent6e88d7cef072e1b504f5d428a2ce7d8aff736a8d
Fix crash during shutdown

Summary:
Fix crash during shutdown. The root cause is that when Dolphin in stopped as
part of an activity, the KItemListViewAccessible destructor is called after
QApplication::exec has returned causing Qt to already having cleaned up the
QAccessibleInterface instances kept in KItemListViewAccessible. Instead of
storing the pointers to QAccessibleInterface we store the QAccessible::Id so
that we can use the QAccessible::deleteAccessibleInterface function for
deleting the instances.

BUG: 402784

Test Plan:
I wasn't able to reproduce the crash in the first place, but I have just
opened and closed Dolphin a few times and verified the the QAccessibleInterface
instances are correctly cleaned up.

Reviewers: #dolphin, elvisangelaccio, ngraham

Reviewed By: #dolphin, elvisangelaccio

Subscribers: kfm-devel

Tags: #dolphin

Differential Revision: https://phabricator.kde.org/D19083
src/kitemviews/kitemlistviewaccessible.cpp
src/kitemviews/kitemlistviewaccessible.h