]> cloud.milkyroute.net Git - dolphin.git/commit
Keep org.freedesktop.FileManager1 registered across processes
authorDavid Edmundson <kde@davidedmundson.co.uk>
Mon, 17 Sep 2018 10:02:51 +0000 (12:02 +0200)
committerDavid Edmundson <kde@davidedmundson.co.uk>
Mon, 17 Sep 2018 10:04:00 +0000 (12:04 +0200)
commitcb6c71ae1b7e2a19c876608e375f7ba7068977a3
treeb7fac3acd8d9c474c07dfe1ad19ceca9bd7f94e6
parentb98948ae1e036e46501e91aa0f074f9728d26ab2
Keep org.freedesktop.FileManager1 registered across processes

Summary:
Currently if someone starts 2 dolphins, the second cannot register
org.freedesktop.FileManager1 meaning and when the first dolphin quits,
no-one has it registered.

It doesn't cause a huge problem right now as we just dbus-activate a new one if
needed, but it means the behaviour is a bit inconsistent and
non-optimal.

DBus has a system to queue names, meaning that as long as any dolphin is
running this name is owned by one of the processes.

Also this patch registers the service after the object which is
technically safer.

Test Plan:
Ran d-feet
Opened 2 dolphins, closed the first
Service was still registered and the PID of the owning process changed.

Reviewers: #dolphin, elvisangelaccio

Reviewed By: #dolphin, elvisangelaccio

Subscribers: elvisangelaccio, kfm-devel

Tags: #dolphin

Differential Revision: https://phabricator.kde.org/D15539
src/dbusinterface.cpp