]> cloud.milkyroute.net Git - dolphin.git/commit
[InformationPanel] Use the new inline configuration mode
authorStefan Brüns <stefan.bruens@rwth-aachen.de>
Sun, 14 Apr 2019 00:44:01 +0000 (02:44 +0200)
committerStefan Brüns <stefan.bruens@rwth-aachen.de>
Tue, 23 Apr 2019 10:36:14 +0000 (12:36 +0200)
commitecf1ae6d0b1691bfe36fc0ff64500f111f3abc32
tree34b793728e69071b1a27f6bc83b420a5661d302e
parent8dc5c7a199ae69a37fb423860897b312bc4a11ba
[InformationPanel] Use the new inline configuration mode

Summary:
The current external configuration dialog has some issues:

- its layout is suboptimal, as its initial size is typically to small
- it is quite disassociated with the actual widget it configures, properties
  have a different order, and the property names can be quite abstract
  without the corresponding value.

Doing the visibility selection inline typically avoids the sizing problem,
as the containing application (dolphin) is often vertically maximized.
The selection becomes more obvious, as the item order is kept,
and the values are shown.

Depends on D20524

CCBUG: 389571

Reviewers: #dolphin, #baloo, #frameworks, ngraham, astippich, #vdg, elvisangelaccio

Reviewed By: #dolphin, elvisangelaccio

Subscribers: elvisangelaccio, meven, kfm-devel

Tags: #dolphin

Differential Revision: https://phabricator.kde.org/D20525
CMakeLists.txt
src/CMakeLists.txt
src/panels/information/filemetadataconfigurationdialog.cpp [deleted file]
src/panels/information/filemetadataconfigurationdialog.h [deleted file]
src/panels/information/informationpanel.cpp
src/panels/information/informationpanel.h
src/panels/information/informationpanelcontent.cpp
src/panels/information/informationpanelcontent.h