]> cloud.milkyroute.net Git - dolphin.git/commit
Add explicit moc includes to sources for moc-covered headers
authorFriedrich W. H. Kossebau <kossebau@kde.org>
Tue, 4 Jul 2023 20:07:48 +0000 (22:07 +0200)
committerMéven Car <meven.car@kdemail.net>
Wed, 5 Jul 2023 07:59:18 +0000 (07:59 +0000)
commited2d352c42a6d517d4f29b3582c0e00aa34fe647
treed1b487efb15e1d1a6b9ad8c07c3fe2a01f19a505
parent7fcf4e084debda4bddc82de563fbacdabc6a87ef
Add explicit moc includes to sources for moc-covered headers

* speeds up incremental builds as changes to a header will not always
  need the full mocs_compilation.cpp for all the target's headers rebuild,
  while having a moc file sourced into a source file only adds minor
  extra costs, due to small own code and the used headers usually
  already covered by the source file, being for the same class/struct
* seems to not slow down clean builds, due to empty mocs_compilation.cpp
  resulting in those quickly processed, while the minor extra cost of the
  sourced moc files does not outweigh that in summary.
  Measured times actually improved by some percent points.
  (ideally CMake would just skip empty mocs_compilation.cpp & its object
  file one day)
* enables compiler to see all methods of a class in same compilation unit
  to do some sanity checks
* potentially more inlining in general, due to more in the compilation unit
* allows to keep using more forward declarations in the header, as with the
  moc code being sourced into the cpp file there definitions can be ensured
  and often are already for the needs of the normal class methods
106 files changed:
src/dbusinterface.cpp
src/dolphinbookmarkhandler.cpp
src/dolphincontextmenu.cpp
src/dolphindockwidget.cpp
src/dolphinmainwindow.cpp
src/dolphinnavigatorswidgetaction.cpp
src/dolphinnewfilemenu.cpp
src/dolphinpart.cpp
src/dolphinpart_ext.cpp
src/dolphinplacesmodelsingleton.cpp
src/dolphinrecenttabsmenu.cpp
src/dolphinremoveaction.cpp
src/dolphintabbar.cpp
src/dolphintabpage.cpp
src/dolphintabwidget.cpp
src/dolphinurlnavigator.cpp
src/dolphinurlnavigatorscontroller.cpp
src/dolphinviewcontainer.cpp
src/filterbar/filterbar.cpp
src/global.cpp
src/kitemviews/kfileitemlistview.cpp
src/kitemviews/kfileitemlistwidget.cpp
src/kitemviews/kfileitemmodel.cpp
src/kitemviews/kfileitemmodelrolesupdater.cpp
src/kitemviews/kitemlistcontainer.cpp
src/kitemviews/kitemlistcontroller.cpp
src/kitemviews/kitemlistgroupheader.cpp
src/kitemviews/kitemlistheader.cpp
src/kitemviews/kitemlistselectionmanager.cpp
src/kitemviews/kitemlistview.cpp
src/kitemviews/kitemlistwidget.cpp
src/kitemviews/kitemmodelbase.cpp
src/kitemviews/kstandarditemlistgroupheader.cpp
src/kitemviews/kstandarditemlistview.cpp
src/kitemviews/kstandarditemlistwidget.cpp
src/kitemviews/private/kdirectorycontentscounter.cpp
src/kitemviews/private/kdirectorycontentscounterworker.cpp
src/kitemviews/private/kfileitemclipboard.cpp
src/kitemviews/private/kitemlistheaderwidget.cpp
src/kitemviews/private/kitemlistkeyboardsearchmanager.cpp
src/kitemviews/private/kitemlistroleeditor.cpp
src/kitemviews/private/kitemlistrubberband.cpp
src/kitemviews/private/kitemlistselectiontoggle.cpp
src/kitemviews/private/kitemlistsmoothscroller.cpp
src/kitemviews/private/kitemlistviewanimation.cpp
src/kitemviews/private/kitemlistviewlayouter.cpp
src/middleclickactioneventfilter.cpp
src/panels/folders/foldersitemlistwidget.cpp
src/panels/folders/folderspanel.cpp
src/panels/folders/treeviewcontextmenu.cpp
src/panels/information/informationpanel.cpp
src/panels/information/informationpanelcontent.cpp
src/panels/information/phononwidget.cpp
src/panels/information/pixmapviewer.cpp
src/panels/panel.cpp
src/panels/places/placespanel.cpp
src/panels/terminal/terminalpanel.cpp
src/search/dolphinfacetswidget.cpp
src/search/dolphinsearchbox.cpp
src/selectionmode/bottombar.cpp
src/selectionmode/bottombarcontentscontainer.cpp
src/selectionmode/topbar.cpp
src/settings/applyviewpropsjob.cpp
src/settings/contextmenu/contextmenusettingspage.cpp
src/settings/dolphinsettingsdialog.cpp
src/settings/general/behaviorsettingspage.cpp
src/settings/general/configurepreviewplugindialog.cpp
src/settings/general/confirmationssettingspage.cpp
src/settings/general/generalsettingspage.cpp
src/settings/general/previewssettingspage.cpp
src/settings/general/statusbarsettingspage.cpp
src/settings/kcm/kcmdolphingeneral.cpp
src/settings/kcm/kcmdolphinnavigation.cpp
src/settings/kcm/kcmdolphinviewmodes.cpp
src/settings/navigation/navigationsettingspage.cpp
src/settings/serviceitemdelegate.cpp
src/settings/servicemodel.cpp
src/settings/settingspagebase.cpp
src/settings/startup/startupsettingspage.cpp
src/settings/trash/trashsettingspage.cpp
src/settings/userfeedback/userfeedbacksettingspage.cpp
src/settings/viewmodes/contentdisplaytab.cpp
src/settings/viewmodes/dolphinfontrequester.cpp
src/settings/viewmodes/viewsettingspage.cpp
src/settings/viewmodes/viewsettingstab.cpp
src/settings/viewpropertiesdialog.cpp
src/settings/viewpropsprogressinfo.cpp
src/statusbar/dolphinstatusbar.cpp
src/statusbar/mountpointobserver.cpp
src/statusbar/mountpointobservercache.cpp
src/statusbar/spaceinfoobserver.cpp
src/statusbar/statusbarspaceinfo.cpp
src/trash/dolphintrash.cpp
src/userfeedback/dolphinfeedbackprovider.cpp
src/views/dolphinfileitemlistwidget.cpp
src/views/dolphinitemlistview.cpp
src/views/dolphinnewfilemenuobserver.cpp
src/views/dolphinremoteencoding.cpp
src/views/dolphinview.cpp
src/views/dolphinviewactionhandler.cpp
src/views/tooltips/dolphinfilemetadatawidget.cpp
src/views/tooltips/tooltipmanager.cpp
src/views/versioncontrol/kversioncontrolplugin.cpp
src/views/versioncontrol/updateitemstatesthread.cpp
src/views/versioncontrol/versioncontrolobserver.cpp
src/views/viewmodecontroller.cpp