]> cloud.milkyroute.net Git - dolphin.git/commit
Fix broken view state restoration
authorFrank Reininghaus <frank78ac@googlemail.com>
Sat, 26 Oct 2013 07:24:04 +0000 (09:24 +0200)
committerFrank Reininghaus <frank78ac@googlemail.com>
Sat, 26 Oct 2013 07:24:04 +0000 (09:24 +0200)
commitf55119945f0edc369b53c64b45ae117dc73ff426
tree848d3f45981b8a73f2a4483bbcbd0dd1f9cfe3e6
parent96ba990d865b2dfb966961061ba5154dcd3187b4
Fix broken view state restoration

The fix for bug 161385 (which was about Dolphin still showing an empty
view if a device that had been unmounted earlier was clicked in the
Places Panel) caused a regression: the view state (current item, scroll
position, Details View expansion state) was not restored any more when
going "Back".

The reason is that "m_view->reload()" in
DolphinViewContainer::setUrl(const KUrl& newUrl) was always executed
just after entering a directory, and that command overwrites this
information.

Distinguishing between "change URL" and "reload the view" works better
if it's done in DolphinMainWindow instead of DolphinViewContainer.

BUG: 326039
FIXED-IN: 4.11.3
REVIEW: 113290
src/dolphinmainwindow.cpp
src/dolphinmainwindow.h
src/dolphinviewcontainer.cpp