From: Felix Ernst Date: Fri, 23 Jun 2023 17:07:10 +0000 (+0200) Subject: Move focus from hiding selection mode bars to view X-Git-Url: https://cloud.milkyroute.net/gitweb/dolphin.git/commitdiff_plain/0bf439833c489b6eb0e629271010b59ba90b8fa6 Move focus from hiding selection mode bars to view When a user exits selection mode for example by clicking the "Exit Selection Mode" button, the bar is closed but the focus doesn't return to the view which would be expected. This commit actively moves the focus to the view in such a scenario. BUG: 469621 --- diff --git a/src/dolphinviewcontainer.cpp b/src/dolphinviewcontainer.cpp index 8627891c0..5a4540786 100644 --- a/src/dolphinviewcontainer.cpp +++ b/src/dolphinviewcontainer.cpp @@ -37,6 +37,7 @@ #include #include +#include #include #include #include @@ -343,6 +344,9 @@ void DolphinViewContainer::setSelectionModeEnabled(bool enabled, KActionCollecti } Q_CHECK_PTR(m_selectionModeTopBar); // there is no point in disabling selectionMode when it wasn't even enabled once. Q_CHECK_PTR(m_selectionModeBottomBar); + if (m_selectionModeTopBar->isAncestorOf(QApplication::focusWidget()) || m_selectionModeBottomBar->isAncestorOf(QApplication::focusWidget())) { + m_view->setFocus(); + } m_selectionModeTopBar->setVisible(false, WithAnimation); m_selectionModeBottomBar->setVisible(false, WithAnimation); Q_EMIT selectionModeChanged(false);