From: Nicolas Fella <nicolas.fella@gmx.de>
Date: Tue, 24 Oct 2023 21:12:22 +0000 (+0200)
Subject: Merge branch 'master' into kf6
X-Git-Url: https://cloud.milkyroute.net/gitweb/dolphin.git/commitdiff_plain/1826f905d706925456763394de17294bcb6d1c35

Merge branch 'master' into kf6
---

1826f905d706925456763394de17294bcb6d1c35
diff --cc src/kitemviews/kstandarditemlistwidget.cpp
index 52df17ad3,0088e4116..e37013f95
--- a/src/kitemviews/kstandarditemlistwidget.cpp
+++ b/src/kitemviews/kstandarditemlistwidget.cpp
@@@ -1347,8 -1357,8 +1357,8 @@@ void KStandardItemListWidget::updateCom
      const qreal x = option.padding * 3 + iconSize();
      qreal y = qRound((widgetHeight - textLinesHeight) / 2);
      const qreal maxWidth = size().width() - x - option.padding;
 -    for (const QByteArray &role : qAsConst(m_sortedVisibleRoles)) {
 +    for (const QByteArray &role : std::as_const(m_sortedVisibleRoles)) {
-         const QString text = roleText(role, values);
+         const QString text = escapeString(roleText(role, values));
          TextInfo *textInfo = m_textInfo.value(role);
          textInfo->staticText.setText(text);
  
diff --cc src/settings/contextmenu/contextmenusettingspage.cpp
index 68073a16e,c81078095..a1fada2ad
--- a/src/settings/contextmenu/contextmenusettingspage.cpp
+++ b/src/settings/contextmenu/contextmenusettingspage.cpp
@@@ -170,11 -176,10 +170,10 @@@ void ContextMenuSettingsPage::applySett
  
      QStringList enabledPlugins;
  
-     const QAbstractItemModel *model = m_listView->model();
-     for (int i = 0; i < model->rowCount(); ++i) {
-         const QModelIndex index = model->index(i, 0);
-         const QString service = model->data(index, ServiceModel::DesktopEntryNameRole).toString();
-         const bool checked = model->data(index, Qt::CheckStateRole).value<Qt::CheckState>() == Qt::Checked;
+     for (int i = 0; i < m_serviceModel->rowCount(); ++i) {
+         const QModelIndex index = m_serviceModel->index(i, 0);
+         const QString service = m_serviceModel->data(index, ServiceModel::DesktopEntryNameRole).toString();
 -        const bool checked = m_serviceModel->data(index, Qt::CheckStateRole).toBool();
++        const bool checked = m_serviceModel->data(index, Qt::CheckStateRole).value<Qt::CheckState>() == Qt::Checked;
  
          if (service.startsWith(VersionControlServicePrefix)) {
              if (checked) {
@@@ -230,7 -234,7 +228,7 @@@ void ContextMenuSettingsPage::restoreDe
  
          const bool checked =
              !service.startsWith(VersionControlServicePrefix) && service != QLatin1String(DeleteService) && service != QLatin1String(CopyToMoveToService);
-         model->setData(index, checked ? Qt::Checked : Qt::Unchecked, Qt::CheckStateRole);
 -        m_serviceModel->setData(index, checked, Qt::CheckStateRole);
++        m_serviceModel->setData(index, checked ? Qt::Checked : Qt::Unchecked, Qt::CheckStateRole);
      }
  }