From: Peter Penz <peter.penz19@gmail.com>
Date: Mon, 7 Dec 2009 22:15:54 +0000 (+0000)
Subject: don't crash if the Information Panel is updated by file changes
X-Git-Url: https://cloud.milkyroute.net/gitweb/dolphin.git/commitdiff_plain/1b05d108a108c6f1d5a718620fc18341ec07a19e

don't crash if the Information Panel is updated by file changes

BUG: 214060

svn path=/trunk/KDE/kdebase/apps/; revision=1060022
---

diff --git a/src/panels/information/kmetadatawidget.cpp b/src/panels/information/kmetadatawidget.cpp
index 5d019691b..d653058eb 100644
--- a/src/panels/information/kmetadatawidget.cpp
+++ b/src/panels/information/kmetadatawidget.cpp
@@ -343,7 +343,12 @@ void KMetaDataWidget::Private::updateRowsVisibility()
 void KMetaDataWidget::Private::slotLoadingFinished()
 {
 #ifdef HAVE_NEPOMUK
-    Q_ASSERT(m_loadMetaDataThread != 0);
+    if (m_loadMetaDataThread == 0) {
+        // The signal finished() has been emitted, but the thread has been marked
+        // as invalid in the meantime. Just ignore the signal in this case.
+        return;
+    }
+
     Q_ASSERT(m_ratingWidget != 0);
     Q_ASSERT(m_commentWidget != 0);
     Q_ASSERT(m_taggingWidget != 0);