From: Nate Graham <nate@kde.org>
Date: Fri, 7 Jun 2019 15:50:53 +0000 (-0600)
Subject: Make Bookmarks item work properly as a toolbar item
X-Git-Url: https://cloud.milkyroute.net/gitweb/dolphin.git/commitdiff_plain/1bcd47842224509964229a0bddc2277dfe1467da

Make Bookmarks item work properly as a toolbar item
- Make its menu open on click, not click-and-hold
- Give it a proper icon

BUG: 408346
FIXED-IN: 19.08.0
---

diff --git a/src/dolphinmainwindow.cpp b/src/dolphinmainwindow.cpp
index 385b61a2a..c839e2d5c 100644
--- a/src/dolphinmainwindow.cpp
+++ b/src/dolphinmainwindow.cpp
@@ -1275,6 +1275,9 @@ void DolphinMainWindow::setupActions()
 
     // setup 'Bookmarks' menu
     KActionMenu *bookmarkMenu = new KActionMenu(i18nc("@title:menu", "&Bookmarks"), this);
+    bookmarkMenu->setIcon(QIcon::fromTheme(QStringLiteral("bookmarks")));
+    // Make the toolbar button version work properly on click
+    bookmarkMenu->setDelayed(false);
     m_bookmarkHandler = new DolphinBookmarkHandler(this, actionCollection(), bookmarkMenu->menu(), this);
     actionCollection()->addAction(QStringLiteral("bookmarks"), bookmarkMenu);