From: Peter Penz <peter.penz19@gmail.com>
Date: Fri, 14 Aug 2009 20:36:54 +0000 (+0000)
Subject: - Fixed issue that the items inside the "Other" category are sorted in a wrong manner.
X-Git-Url: https://cloud.milkyroute.net/gitweb/dolphin.git/commitdiff_plain/1d75c9dcae51877d15aff53b27e13f542a1bafe0?ds=inline

- Fixed issue that the items inside the "Other" category are sorted in a wrong manner.

- Removed redundant code.

BUG: 173027

svn path=/trunk/KDE/kdebase/apps/; revision=1011495
---

diff --git a/src/dolphinmodel.cpp b/src/dolphinmodel.cpp
index 3b507a895..503c1086d 100644
--- a/src/dolphinmodel.cpp
+++ b/src/dolphinmodel.cpp
@@ -217,11 +217,7 @@ QVariant DolphinModel::displayRoleData(const QModelIndex& index) const
                     }
                 }
 
-                if (!validCategory) {
-                    retString = validCategory ? *currA : i18nc("@title:group Name", m_others);
-                } else {
-                    retString = *currA;
-                }
+                retString = validCategory ? *currA : i18nc("@title:group Name", m_others);
             }
         }
         break;
@@ -393,7 +389,7 @@ QVariant DolphinModel::sortRoleData(const QModelIndex& index) const
         retVariant = data(index, KCategorizedSortFilterProxyModel::CategoryDisplayRole);
         if (retVariant == i18nc("@title:group Name", m_others)) {
             // assure that the "Others" group is always the last categorization
-            retVariant = QString(QChar(QChar::ReplacementCharacter));
+            retVariant = QString('Z').append(QChar::ReplacementCharacter);
         }
         break;
     }