From: Alexander Lohnau <alexander.lohnau@gmx.de>
Date: Fri, 11 Dec 2020 19:05:15 +0000 (+0100)
Subject: Do not create instance of GeneralSettings just to access static members
X-Git-Url: https://cloud.milkyroute.net/gitweb/dolphin.git/commitdiff_plain/20370b4c9fe1958b9f222c86bfa39439a7847545?ds=sidebyside;hp=-c

Do not create instance of GeneralSettings just to access static members
---

20370b4c9fe1958b9f222c86bfa39439a7847545
diff --git a/src/dolphinmainwindow.cpp b/src/dolphinmainwindow.cpp
index beec95c6c..27949fb17 100644
--- a/src/dolphinmainwindow.cpp
+++ b/src/dolphinmainwindow.cpp
@@ -134,10 +134,9 @@ DolphinMainWindow::DolphinMainWindow() :
     connect(undoManager, &KIO::FileUndoManager::jobRecordingFinished,
             this, &DolphinMainWindow::showCommand);
 
-    GeneralSettings* generalSettings = GeneralSettings::self();
-    const bool firstRun = (generalSettings->version() < 200);
+    const bool firstRun = (GeneralSettings::version() < 200);
     if (firstRun) {
-        generalSettings->setViewPropsTimestamp(QDateTime::currentDateTime());
+        GeneralSettings::setViewPropsTimestamp(QDateTime::currentDateTime());
     }
 
     setAcceptDrops(true);
@@ -174,7 +173,7 @@ DolphinMainWindow::DolphinMainWindow() :
             this, &DolphinMainWindow::updatePasteAction);
 
     QAction* toggleFilterBarAction = actionCollection()->action(QStringLiteral("toggle_filter"));
-    toggleFilterBarAction->setChecked(generalSettings->filterBar());
+    toggleFilterBarAction->setChecked(GeneralSettings::filterBar());
 
     if (firstRun) {
         menuBar()->setVisible(false);