From: Emmanuel Pescosta <emmanuelpescosta099@gmail.com>
Date: Thu, 24 Apr 2014 18:57:18 +0000 (+0200)
Subject: Fix memory leak with Dropbox version control plugin.
X-Git-Url: https://cloud.milkyroute.net/gitweb/dolphin.git/commitdiff_plain/272cbbd16b03e51b30b6b9d472aa56054a5ea036

Fix memory leak with Dropbox version control plugin.

In the current version we only call endRetrieval when
beginRetrieval was successfully in UpdateItemStatesThread::run().
This causes some problems with version control plugins (like Dropbox plugin),
which have to do cleanups in endRetrieval.

Now we always call endRetrieval after beginRetrieval when updating the version states.

FIXED-IN: 4.13.1
REVIEW: 117753
---

diff --git a/src/views/versioncontrol/updateitemstatesthread.cpp b/src/views/versioncontrol/updateitemstatesthread.cpp
index 6457f607d..62fcd09aa 100644
--- a/src/views/versioncontrol/updateitemstatesthread.cpp
+++ b/src/views/versioncontrol/updateitemstatesthread.cpp
@@ -64,9 +64,9 @@ void UpdateItemStatesThread::run()
                     items[i].version = static_cast<KVersionControlPlugin2::ItemVersion>(state);
                 }
             }
-
-            m_plugin->endRetrieval();
         }
+
+        m_plugin->endRetrieval();
     }
 }