From: Emmanuel Pescosta <emmanuelpescosta099@gmail.com>
Date: Sat, 24 Aug 2013 19:00:26 +0000 (+0200)
Subject: Adjust the size and position of the selection toggle on icon
X-Git-Url: https://cloud.milkyroute.net/gitweb/dolphin.git/commitdiff_plain/2bdce34fe1e6613d2747ab798bccb4fa7de8ca3e?ds=sidebyside

Adjust the size and position of the selection toggle on icon
resize (when changing the zoomlevel).

BUG: 310412
REVIEW: 112250
FIXED-IN: 4.11.1
---

diff --git a/src/kitemviews/kitemlistwidget.cpp b/src/kitemviews/kitemlistwidget.cpp
index 6a7111ad7..85cd70c43 100644
--- a/src/kitemviews/kitemlistwidget.cpp
+++ b/src/kitemviews/kitemlistwidget.cpp
@@ -451,6 +451,12 @@ void KItemListWidget::resizeEvent(QGraphicsSceneResizeEvent* event)
 {
     QGraphicsWidget::resizeEvent(event);
     clearHoverCache();
+
+    if (m_selectionToggle) {
+        const QRectF& toggleRect = selectionToggleRect();
+        m_selectionToggle->setPos(toggleRect.topLeft());
+        m_selectionToggle->resize(toggleRect.size());
+    }
 }
 
 qreal KItemListWidget::hoverOpacity() const
diff --git a/src/kitemviews/private/kitemlistselectiontoggle.cpp b/src/kitemviews/private/kitemlistselectiontoggle.cpp
index 66da6a727..6bbf3c2ec 100644
--- a/src/kitemviews/private/kitemlistselectiontoggle.cpp
+++ b/src/kitemviews/private/kitemlistselectiontoggle.cpp
@@ -79,28 +79,49 @@ void KItemListSelectionToggle::hoverLeaveEvent(QGraphicsSceneHoverEvent* event)
     m_pixmap = QPixmap();
 }
 
+void KItemListSelectionToggle::resizeEvent(QGraphicsSceneResizeEvent* event)
+{
+    QGraphicsWidget::resizeEvent(event);
+
+    if (!m_pixmap.isNull()) {
+        const int pixmapSize = m_pixmap.size().width(); // Pixmap width is always equal pixmap height
+
+        if (pixmapSize != iconSize()) {
+            // If the required icon size is different from the actual pixmap size,
+            // overwrite the m_pixmap with an empty pixmap and reload the new
+            // icon on next re-painting.
+            m_pixmap = QPixmap();
+        }
+    }
+}
+
 void KItemListSelectionToggle::updatePixmap()
 {
     const char* icon = m_checked ? "list-remove" : "list-add";
+    m_pixmap = KIconLoader::global()->loadIcon(QLatin1String(icon), KIconLoader::NoGroup, iconSize());
+
+    if (m_hovered) {
+        KIconLoader::global()->iconEffect()->apply(m_pixmap, KIconLoader::Desktop, KIconLoader::ActiveState);
+    }
+}
+
+int KItemListSelectionToggle::iconSize() const
+{
+    const int iconSize = qMin(size().width(), size().height());
 
-    int iconSize = qMin(size().width(), size().height());
     if (iconSize < KIconLoader::SizeSmallMedium) {
-        iconSize = KIconLoader::SizeSmall;
+        return KIconLoader::SizeSmall;
     } else if (iconSize < KIconLoader::SizeMedium) {
-        iconSize = KIconLoader::SizeSmallMedium;
+        return KIconLoader::SizeSmallMedium;
     } else if (iconSize < KIconLoader::SizeLarge) {
-        iconSize = KIconLoader::SizeMedium;
+        return KIconLoader::SizeMedium;
     } else if (iconSize < KIconLoader::SizeHuge) {
-        iconSize = KIconLoader::SizeLarge;
+        return KIconLoader::SizeLarge;
     } else if (iconSize < KIconLoader::SizeEnormous) {
-        iconSize = KIconLoader::SizeHuge;
+        return KIconLoader::SizeHuge;
     }
 
-    m_pixmap = KIconLoader::global()->loadIcon(QLatin1String(icon), KIconLoader::NoGroup, iconSize);
-
-    if (m_hovered) {
-        KIconLoader::global()->iconEffect()->apply(m_pixmap, KIconLoader::Desktop, KIconLoader::ActiveState);
-    }
+    return iconSize;
 }
 
 #include "kitemlistselectiontoggle.moc"
diff --git a/src/kitemviews/private/kitemlistselectiontoggle.h b/src/kitemviews/private/kitemlistselectiontoggle.h
index a8050d811..ba29293f6 100644
--- a/src/kitemviews/private/kitemlistselectiontoggle.h
+++ b/src/kitemviews/private/kitemlistselectiontoggle.h
@@ -46,9 +46,11 @@ public:
 protected:
     virtual void hoverEnterEvent(QGraphicsSceneHoverEvent* event);
     virtual void hoverLeaveEvent(QGraphicsSceneHoverEvent* event);
+    virtual void resizeEvent(QGraphicsSceneResizeEvent* event);
 
 private:
     void updatePixmap();
+    int iconSize() const;
 
 private:
     bool m_checked;