From: Frank Reininghaus <frank78ac@googlemail.com>
Date: Sun, 22 Dec 2013 12:17:05 +0000 (+0100)
Subject: Fix crash when dragging children of expanded folders in Details View
X-Git-Url: https://cloud.milkyroute.net/gitweb/dolphin.git/commitdiff_plain/2e4991d5f095170ab0b306bbdfb9eaa38a5f3f03

Fix crash when dragging children of expanded folders in Details View

The problem was that the loop in KFileItemModel::createMimeData() which
is supposed to find out if any parent of an item has been added to the
QMimeData already (because it is not necessary to add the item in that
case) did not loop through the parents of the item, but incorrectly
replaced the local variable 'itemData' by its parent.

BUG: 329119
REVIEW: 114562
---

diff --git a/src/kitemviews/kfileitemmodel.cpp b/src/kitemviews/kfileitemmodel.cpp
index 4521374e6..058248a18 100644
--- a/src/kitemviews/kfileitemmodel.cpp
+++ b/src/kitemviews/kfileitemmodel.cpp
@@ -253,7 +253,7 @@ QMimeData* KFileItemModel::createMimeData(const KItemSet& indexes) const
         const ItemData* parent = itemData->parent;
 
         while (parent && parent != lastAddedItem) {
-            itemData = itemData->parent;
+            parent = parent->parent;
         }
 
         if (parent && parent == lastAddedItem) {