From: Ismael Asensio <isma.af@mgmail.com>
Date: Sun, 6 Oct 2019 09:34:30 +0000 (+0200)
Subject: Fix crash when lauching dolphin with a search scheme
X-Git-Url: https://cloud.milkyroute.net/gitweb/dolphin.git/commitdiff_plain/31fd775f368f61f6dde54c0c3a2e83d65599c3c2

Fix crash when lauching dolphin with a search scheme

Summary: Widget objects are initialized in `DolphinSearchBox::init()`, which is called on `QEvent::Polish`, so we must set it visible before calling `fromSearchUrl`.

Test Plan: `dolphin --new-window baloosearch://`

Reviewers: #dolphin, elvisangelaccio

Subscribers: kfm-devel

Tags: #dolphin

Differential Revision: https://phabricator.kde.org/D24432
---

diff --git a/src/dolphinviewcontainer.cpp b/src/dolphinviewcontainer.cpp
index c6d9d89ad..536ab0fa8 100644
--- a/src/dolphinviewcontainer.cpp
+++ b/src/dolphinviewcontainer.cpp
@@ -385,6 +385,9 @@ bool DolphinViewContainer::isFilterBarVisible() const
 
 void DolphinViewContainer::setSearchModeEnabled(bool enabled)
 {
+    m_searchBox->setVisible(enabled);
+    m_navigatorWidget->setVisible(!enabled);
+
     if (enabled) {
         const QUrl& locationUrl = m_urlNavigator->locationUrl();
         m_searchBox->fromSearchUrl(locationUrl);
@@ -398,9 +401,6 @@ void DolphinViewContainer::setSearchModeEnabled(bool enabled)
         return;
     }
 
-    m_searchBox->setVisible(enabled);
-    m_navigatorWidget->setVisible(!enabled);
-
     if (!enabled) {
         m_view->setViewPropertiesContext(QString());