From: Elvis Angelaccio <elvis.angelaccio@kde.org>
Date: Wed, 13 Jun 2018 21:16:33 +0000 (+0200)
Subject: ViewPropertiesDialog: disable Apply button on startup
X-Git-Url: https://cloud.milkyroute.net/gitweb/dolphin.git/commitdiff_plain/32b8b19ba556a5429e9b70e7d2cac9e468faf08a?ds=inline

ViewPropertiesDialog: disable Apply button on startup

We call `markAsDirty(false)` at the end of `loadSettings()` but that's
not enough, because `m_isDirty` is initialized to false (as it should be).
This means `isDirtyChanged` is not emitted and the button is not disabled.

By disabling it explicitly, we make it consistent with the Apply button
in the settings dialog (which is also initially disabled).
---

diff --git a/src/settings/viewpropertiesdialog.cpp b/src/settings/viewpropertiesdialog.cpp
index dbbf5fa68..60c9f21f5 100644
--- a/src/settings/viewpropertiesdialog.cpp
+++ b/src/settings/viewpropertiesdialog.cpp
@@ -196,6 +196,7 @@ ViewPropertiesDialog::ViewPropertiesDialog(DolphinView* dolphinView) :
     okButton->setDefault(true);
 
     auto applyButton = buttonBox->button(QDialogButtonBox::Apply);
+    applyButton->setEnabled(false);
     connect(applyButton, &QPushButton::clicked, this, &ViewPropertiesDialog::slotApply);
     connect(this, &ViewPropertiesDialog::isDirtyChanged, applyButton, [applyButton](bool isDirty) {
         applyButton->setEnabled(isDirty);