From: David Faure <faure@kde.org>
Date: Fri, 15 Oct 2010 00:15:13 +0000 (+0000)
Subject: Enable dropping of raw data, like one could do in KDE3. It's actually working fine... 
X-Git-Url: https://cloud.milkyroute.net/gitweb/dolphin.git/commitdiff_plain/363e5b69dda38a963f8fc4b5145eee4732bc31d9

Enable dropping of raw data, like one could do in KDE3. It's actually working fine with text data for instance,
only image data is still an issue due to bugs in Qt. This will be in KDE 4.6.
CCBUG: 159337

svn path=/trunk/KDE/kdebase/apps/; revision=1186021
---

diff --git a/src/views/draganddrophelper.cpp b/src/views/draganddrophelper.cpp
index 0cca59ac4..8ab96d368 100644
--- a/src/views/draganddrophelper.cpp
+++ b/src/views/draganddrophelper.cpp
@@ -49,7 +49,10 @@ DragAndDropHelper& DragAndDropHelper::instance()
 
 bool DragAndDropHelper::isMimeDataSupported(const QMimeData* mimeData) const
 {
-    return mimeData->hasUrls() || mimeData->hasFormat("application/x-kde-dndextract");
+    // We support everything, cf KonqOperations::doDrop which can save any data.
+    //return mimeData->hasUrls() || mimeData->hasFormat("application/x-kde-dndextract");
+    Q_UNUSED(mimeData);
+    return true;
 }
 
 void DragAndDropHelper::startDrag(QAbstractItemView* itemView,
@@ -109,9 +112,7 @@ void DragAndDropHelper::dropUrls(const KFileItem& destItem,
     } else {
         const KUrl::List urls = KUrl::List::fromMimeData(event->mimeData());
         const int urlsCount = urls.count();
-        if (urlsCount == 0) {
-            // TODO: handle dropping of other data
-        } else if ((urlsCount == 1) && (urls.first() == destination)) {
+        if ((urlsCount == 1) && (urls.first() == destination)) {
             emit errorMessage(i18nc("@info:status", "A folder cannot be dropped into itself"));
         } else if (dropToItem) {
             KonqOperations::doDrop(destItem, destination, event, widget);