From: Akseli Lahtinen <akselmo@akselmo.dev>
Date: Wed, 13 Nov 2024 09:46:32 +0000 (+0200)
Subject: FoldersTabsSettingsPage: Remove double cast, remove unnecessary variable
X-Git-Url: https://cloud.milkyroute.net/gitweb/dolphin.git/commitdiff_plain/3d47d7060344ce41241cc13112111a164619c169?hp=4f0bb805d2c3dfdfc87c5000a6a3675da1d8b6c2

FoldersTabsSettingsPage: Remove double cast, remove unnecessary variable

This uses only qobject_cast here, having static_cast after it is
redundant.

Also remove the topLevelWidgets variable, since we can just
call the method instead.
---

diff --git a/src/settings/interface/folderstabssettingspage.cpp b/src/settings/interface/folderstabssettingspage.cpp
index 0212f624c..c4bc0d740 100644
--- a/src/settings/interface/folderstabssettingspage.cpp
+++ b/src/settings/interface/folderstabssettingspage.cpp
@@ -248,10 +248,9 @@ void FoldersTabsSettingsPage::useCurrentLocation()
 {
 #ifndef IS_KCM
     DolphinMainWindow *mainWindow = nullptr;
-    const auto topLevelWidgets = QApplication::allWidgets();
-    for (const auto widget : topLevelWidgets) {
-        if (qobject_cast<DolphinMainWindow *>(widget)) {
-            mainWindow = static_cast<DolphinMainWindow *>(widget);
+    for (const auto widget : QApplication::topLevelWidgets()) {
+        mainWindow = qobject_cast<DolphinMainWindow *>(widget);
+        if (mainWindow) {
             break;
         }
     }