From: Eugene Popov Date: Sat, 29 Jan 2022 16:35:47 +0000 (+0000) Subject: Revert "[DetailsView] Improve zooming" X-Git-Url: https://cloud.milkyroute.net/gitweb/dolphin.git/commitdiff_plain/43e915213e64f03d785c87cc5cf8db1c6b86a1a2 Revert "[DetailsView] Improve zooming" This reverts commit 7908aff3b5ebe4484d391c1fc4797e9dae2300b2. Reverting this commit will fix the issue of not being able to rename the last file in Details View and will also make the items in Details View and Compact View have the same height. BUG: 447215 FIXED-IN: 21.12.2 --- diff --git a/src/kitemviews/kstandarditemlistwidget.cpp b/src/kitemviews/kstandarditemlistwidget.cpp index 175181271..9c527fa17 100644 --- a/src/kitemviews/kstandarditemlistwidget.cpp +++ b/src/kitemviews/kstandarditemlistwidget.cpp @@ -226,22 +226,8 @@ void KStandardItemListWidgetInformant::calculateCompactLayoutItemSizeHints(QVect void KStandardItemListWidgetInformant::calculateDetailsLayoutItemSizeHints(QVector& logicalHeightHints, qreal& logicalWidthHint, const KItemListView* view) const { const KItemListStyleOption& option = view->styleOption(); - - float zoomLevel = 1; - if (option.iconSize >= KIconLoader::SizeEnormous) { - zoomLevel = 2; - } else if (option.iconSize >= KIconLoader::SizeHuge) { - zoomLevel = 1.8; - } else if (option.iconSize >= KIconLoader::SizeLarge) { - zoomLevel = 1.6; - } else if (option.iconSize >= KIconLoader::SizeMedium) { - zoomLevel = 1.4; - } else if (option.iconSize >= KIconLoader::SizeSmallMedium) { - zoomLevel = 1.2; - } - - const qreal contentHeight = qMax(option.iconSize, zoomLevel * option.fontMetrics.height()); - logicalHeightHints.fill(contentHeight + 2 * option.padding); + const qreal height = option.padding * 2 + qMax(option.iconSize, option.fontMetrics.height()); + logicalHeightHints.fill(height); logicalWidthHint = -1.0; }