From: lzwind lzwind <liuzheng@uniontech.com>
Date: Tue, 29 Jul 2025 13:18:25 +0000 (+0000)
Subject: settings: Fix memory leak in PanelSettingsPage constructor
X-Git-Url: https://cloud.milkyroute.net/gitweb/dolphin.git/commitdiff_plain/44fe65d42110cc200bcb2ce494a026c6a6292c2d

settings: Fix memory leak in PanelSettingsPage constructor

Replace heap-allocated KFormat objects with stack-allocated formatter.
No functionality change.
---

diff --git a/src/settings/interface/panelsettingspage.cpp b/src/settings/interface/panelsettingspage.cpp
index 3cd153656..efa41e6c5 100644
--- a/src/settings/interface/panelsettingspage.cpp
+++ b/src/settings/interface/panelsettingspage.cpp
@@ -28,8 +28,9 @@ PanelSettingsPage::PanelSettingsPage(QWidget *parent)
 {
     QFormLayout *topLayout = new QFormLayout(this);
 
-    QString m_longDateTime = (new KFormat)->formatRelativeDateTime(QDateTime(QDate(2024, 02, 28), QTime(10, 0)), QLocale::LongFormat);
-    QString m_shortDateTime = (new KFormat)->formatRelativeDateTime(QDateTime(QDate(2024, 02, 28), QTime(10, 0)), QLocale::ShortFormat);
+    KFormat formatter;
+    QString m_longDateTime = formatter.formatRelativeDateTime(QDateTime(QDate(2024, 02, 28), QTime(10, 0)), QLocale::LongFormat);
+    QString m_shortDateTime = formatter.formatRelativeDateTime(QDateTime(QDate(2024, 02, 28), QTime(10, 0)), QLocale::ShortFormat);
 
     m_showPreview = new QCheckBox(i18nc("@option:check", "Show previews"), this);
     m_autoPlayMedia = new QCheckBox(i18nc("@option:check", "Auto-play media files"), this);