From: Felix Ernst <fe.a.ernst@gmail.com>
Date: Sat, 27 Aug 2022 09:40:51 +0000 (+0000)
Subject: This commit removes the ability to enter selection mode by
X-Git-Url: https://cloud.milkyroute.net/gitweb/dolphin.git/commitdiff_plain/4ddc4159ed5d9fb6e7b7c6edc1b04460f87c984b

This commit removes the ability to enter selection mode by
click-and-holding with a pointing device like a mouse.

This functionality was originally implemented because it seemed
useful to save users the effort of entering selection mode
explicitly by using its corresponding action.

However, click-and-holding to trigger anything is not really an
expected behaviour. (This contrasts with touch devices where
press-and-holding is common to trigger something.)

Aside from the above reasoning, the click-and-hold behaviour was
also buggy so that selection mode was entered in a couple of
situations that weren't strictly about click-and-holding.

So this commit removes the functionality and the bugs.

BUG: 457973
BUG: 458129
CCBUG: 457975
---

diff --git a/src/kitemviews/kitemlistcontroller.cpp b/src/kitemviews/kitemlistcontroller.cpp
index b589ac356..e1530759b 100644
--- a/src/kitemviews/kitemlistcontroller.cpp
+++ b/src/kitemviews/kitemlistcontroller.cpp
@@ -1060,7 +1060,6 @@ void KItemListController::tapAndHoldTriggered(QGestureEvent* event, const QTrans
 
     //the Qt TabAndHold gesture is triggerable with a mouse click, we don't want this
     if (!m_isTouchEvent) {
-        Q_EMIT selectionModeChangeRequested(true);
         return;
     }