From: Méven Car Date: Mon, 30 May 2022 21:26:09 +0000 (+0200) Subject: kfileitemmodel: sortRoleCompare: allow to sort by access time. X-Git-Url: https://cloud.milkyroute.net/gitweb/dolphin.git/commitdiff_plain/573abcaf25f4629725eafe0282e809e47df1ead3 kfileitemmodel: sortRoleCompare: allow to sort by access time. We had all sorts of weird behavior when sorting by access time. The comparison was simply missing in sortRoleCompare. --- diff --git a/src/kitemviews/kfileitemmodel.cpp b/src/kitemviews/kfileitemmodel.cpp index 0f5cffed1..b1a70f6fa 100644 --- a/src/kitemviews/kfileitemmodel.cpp +++ b/src/kitemviews/kfileitemmodel.cpp @@ -2067,6 +2067,17 @@ int KFileItemModel::sortRoleCompare(const ItemData* a, const ItemData* b, const break; } + case AccessTimeRole: { + const long long dateTimeA = itemA.entry().numberValue(KIO::UDSEntry::UDS_ACCESS_TIME, -1); + const long long dateTimeB = itemB.entry().numberValue(KIO::UDSEntry::UDS_ACCESS_TIME, -1); + if (dateTimeA < dateTimeB) { + return -1; + } else if (dateTimeA > dateTimeB) { + return +1; + } + break; + } + case CreationTimeRole: { const long long dateTimeA = itemA.entry().numberValue(KIO::UDSEntry::UDS_CREATION_TIME, -1); const long long dateTimeB = itemB.entry().numberValue(KIO::UDSEntry::UDS_CREATION_TIME, -1);