From: Simon Paul St James <kdedevel@etotheipiplusone.com>
Date: Wed, 21 Jan 2009 19:43:41 +0000 (+0000)
Subject: Two KFilePreviewGenerator's operating on the same KDirModel can lead to infinite... 
X-Git-Url: https://cloud.milkyroute.net/gitweb/dolphin.git/commitdiff_plain/5b5f0c9d7e5887e39b9dcf080899ca52de4e973f

Two KFilePreviewGenerator's operating on the same KDirModel can lead to infinite loops of preview generation.  If view is not delete'd (e.g. as a result of a FolderExpander), then m_previewGenerator won't be either: delete it manually to prevent having two active at once.

svn path=/trunk/KDE/kdebase/apps/; revision=914799
---

diff --git a/src/dolphinview.cpp b/src/dolphinview.cpp
index ae120777a..cfe447e37 100644
--- a/src/dolphinview.cpp
+++ b/src/dolphinview.cpp
@@ -1360,11 +1360,15 @@ void DolphinView::deleteView()
         }
         view = 0;
 
+        // m_previewGenerator's parent is not always destroyed, and we
+        // don't want two active at once - manually delete.
+        delete m_previewGenerator;
+        m_previewGenerator = 0;
+
         m_iconsView = 0;
         m_detailsView = 0;
         m_columnView = 0;
         m_fileItemDelegate = 0;
-        m_previewGenerator = 0;
         m_toolTipManager = 0;
     }
 }