From: Frank Reininghaus Date: Thu, 7 May 2015 20:06:42 +0000 (+0100) Subject: Simplify the KFileItemModel benchmark X-Git-Url: https://cloud.milkyroute.net/gitweb/dolphin.git/commitdiff_plain/5bde333ca7e9c285f1101bac0434fb4e60b6d4d5 Simplify the KFileItemModel benchmark The benchmark inserted KFileItemLists of different sizes in the model. The intention was to verify that an O(N^2) complexity issue was fixed. However, now that this original problem does not exist any more, the benchmark results are much easier to read, and regressions are much easier to spot at first sight, if only a single list size is used. --- diff --git a/src/tests/kfileitemmodelbenchmark.cpp b/src/tests/kfileitemmodelbenchmark.cpp index 3ff0405fd..41dcce019 100644 --- a/src/tests/kfileitemmodelbenchmark.cpp +++ b/src/tests/kfileitemmodelbenchmark.cpp @@ -81,8 +81,7 @@ void KFileItemModelBenchmark::insertAndRemoveManyItems_data() QTest::addColumn("expectedItemsRemoved"); QList sizes; - sizes << 1000 << 4000 << 16000 << 64000 << 256000; - //sizes << 50000 << 100000 << 150000 << 200000 << 250000; + sizes << 100000; foreach (int n, sizes) { QStringList allStrings;