From: Alexander Lohnau <alexander.lohnau@gmx.de>
Date: Wed, 27 Dec 2023 11:11:53 +0000 (+0100)
Subject: GeneralViewSettingsPage: Initialize variables in header, avoid unused variable depend... 
X-Git-Url: https://cloud.milkyroute.net/gitweb/dolphin.git/commitdiff_plain/5e74b4c0176f73b3f08f34050d675394fa91d2cb

GeneralViewSettingsPage: Initialize variables in header, avoid unused variable depending on config
---

diff --git a/src/settings/viewmodes/generalviewsettingspage.cpp b/src/settings/viewmodes/generalviewsettingspage.cpp
index 0b2a96cb5..a81d46dd2 100644
--- a/src/settings/viewmodes/generalviewsettingspage.cpp
+++ b/src/settings/viewmodes/generalviewsettingspage.cpp
@@ -19,11 +19,6 @@
 GeneralViewSettingsPage::GeneralViewSettingsPage(const QUrl &url, QWidget *parent)
     : SettingsPageBase(parent)
     , m_url(url)
-    , m_localViewProps(nullptr)
-    , m_globalViewProps(nullptr)
-    , m_showToolTips(nullptr)
-    , m_showSelectionToggle(nullptr)
-    , m_renameInline(nullptr)
 {
     QFormLayout *topLayout = new QFormLayout(this);
 
diff --git a/src/settings/viewmodes/generalviewsettingspage.h b/src/settings/viewmodes/generalviewsettingspage.h
index 47838b939..c0e40db59 100644
--- a/src/settings/viewmodes/generalviewsettingspage.h
+++ b/src/settings/viewmodes/generalviewsettingspage.h
@@ -6,6 +6,7 @@
 #ifndef GENERALVIEWSETTINGSPAGE_H
 #define GENERALVIEWSETTINGSPAGE_H
 
+#include "config-dolphin.h"
 #include "settings/settingspagebase.h"
 #include <qradiobutton.h>
 
@@ -37,14 +38,15 @@ private:
 
 private:
     QUrl m_url;
-    QRadioButton *m_localViewProps;
-    QRadioButton *m_globalViewProps;
-    QCheckBox *m_showToolTips;
-    QLabel *m_configureToolTips;
-    QCheckBox *m_showSelectionToggle;
-    QCheckBox *m_renameInline;
-    QCheckBox *m_openArchivesAsFolder;
-    QCheckBox *m_autoExpandFolders;
+    QRadioButton *m_localViewProps = nullptr;
+    QRadioButton *m_globalViewProps = nullptr;
+#if HAVE_BALOO
+    QCheckBox *m_showToolTips = nullptr;
+#endif
+    QCheckBox *m_showSelectionToggle = nullptr;
+    QCheckBox *m_renameInline = nullptr;
+    QCheckBox *m_openArchivesAsFolder = nullptr;
+    QCheckBox *m_autoExpandFolders = nullptr;
 };
 
 #endif