From: Elvis Angelaccio Date: Wed, 24 Oct 2018 20:49:01 +0000 (+0200) Subject: [DolphinViewActionHandler] Rename createDirectory signal X-Git-Url: https://cloud.milkyroute.net/gitweb/dolphin.git/commitdiff_plain/642a427d03c0bf42fd45dac877a70d4fe56e89aa [DolphinViewActionHandler] Rename createDirectory signal Signals should be named after an event that happened. --- diff --git a/src/dolphinmainwindow.cpp b/src/dolphinmainwindow.cpp index 75a340f0a..d9adde66b 100644 --- a/src/dolphinmainwindow.cpp +++ b/src/dolphinmainwindow.cpp @@ -142,7 +142,7 @@ DolphinMainWindow::DolphinMainWindow() : m_actionHandler = new DolphinViewActionHandler(actionCollection(), this); connect(m_actionHandler, &DolphinViewActionHandler::actionBeingHandled, this, &DolphinMainWindow::clearStatusBar); - connect(m_actionHandler, &DolphinViewActionHandler::createDirectory, this, &DolphinMainWindow::createDirectory); + connect(m_actionHandler, &DolphinViewActionHandler::createDirectoryTriggered, this, &DolphinMainWindow::createDirectory); m_remoteEncoding = new DolphinRemoteEncoding(this, m_actionHandler); connect(this, &DolphinMainWindow::urlChanged, diff --git a/src/dolphinpart.cpp b/src/dolphinpart.cpp index 2e7f7639f..f5d4f95b6 100644 --- a/src/dolphinpart.cpp +++ b/src/dolphinpart.cpp @@ -115,7 +115,7 @@ DolphinPart::DolphinPart(QWidget* parentWidget, QObject* parent, const QVariantL m_actionHandler = new DolphinViewActionHandler(actionCollection(), this); m_actionHandler->setCurrentView(m_view); - connect(m_actionHandler, &DolphinViewActionHandler::createDirectory, this, &DolphinPart::createDirectory); + connect(m_actionHandler, &DolphinViewActionHandler::createDirectoryTriggered, this, &DolphinPart::createDirectory); m_remoteEncoding = new DolphinRemoteEncoding(this, m_actionHandler); connect(this, &DolphinPart::aboutToOpenURL, diff --git a/src/views/dolphinviewactionhandler.cpp b/src/views/dolphinviewactionhandler.cpp index 95c140cc5..5697c7f41 100644 --- a/src/views/dolphinviewactionhandler.cpp +++ b/src/views/dolphinviewactionhandler.cpp @@ -95,7 +95,7 @@ void DolphinViewActionHandler::createActions() m_actionCollection->setDefaultShortcut(newDirAction, Qt::Key_F10); newDirAction->setIcon(QIcon::fromTheme(QStringLiteral("folder-new"))); newDirAction->setEnabled(false); // Will be enabled in slotWriteStateChanged(bool) if the current URL is writable - connect(newDirAction, &QAction::triggered, this, &DolphinViewActionHandler::createDirectory); + connect(newDirAction, &QAction::triggered, this, &DolphinViewActionHandler::createDirectoryTriggered); // File menu diff --git a/src/views/dolphinviewactionhandler.h b/src/views/dolphinviewactionhandler.h index be2273917..fa0487e1b 100644 --- a/src/views/dolphinviewactionhandler.h +++ b/src/views/dolphinviewactionhandler.h @@ -93,7 +93,7 @@ Q_SIGNALS: * The receiver of the signal (DolphinMainWindow or DolphinPart) invokes * the method createDirectory of their KNewFileMenu instance. */ - void createDirectory(); + void createDirectoryTriggered(); private Q_SLOTS: /**