From: Frank Reininghaus Date: Sun, 9 Nov 2014 20:57:40 +0000 (+0100) Subject: Make sure that m_selectionToggle is not 0 before calling deleteLater() X-Git-Url: https://cloud.milkyroute.net/gitweb/dolphin.git/commitdiff_plain/7e58ee0133618453441d14d1305d3f1498c9606f Make sure that m_selectionToggle is not 0 before calling deleteLater() Commit 1938ad54d4ee640f04d24bad3b690095bc9b8668 replaced delete by deleteLater(). However, the latter cannot be used safely with null pointers. This commit adds a safety check in order to make sure that we do not get a crash. Thanks to Christoph Feck for pointing out this issue. --- diff --git a/src/kitemviews/kitemlistwidget.cpp b/src/kitemviews/kitemlistwidget.cpp index 46b75588f..97a14763c 100644 --- a/src/kitemviews/kitemlistwidget.cpp +++ b/src/kitemviews/kitemlistwidget.cpp @@ -473,7 +473,7 @@ qreal KItemListWidget::hoverOpacity() const void KItemListWidget::slotHoverAnimationFinished() { - if (!m_hovered) { + if (!m_hovered && m_selectionToggle) { m_selectionToggle->deleteLater(); m_selectionToggle = 0; }