From: Elvis Angelaccio <elvis.angelaccio@kde.org>
Date: Sun, 24 Nov 2019 13:56:53 +0000 (+0100)
Subject: Fix accessibility regression on the Dolphin Control button
X-Git-Url: https://cloud.milkyroute.net/gitweb/dolphin.git/commitdiff_plain/82e366f024cb47106f0195e53f97c5beea2e798a?ds=sidebyside

Fix accessibility regression on the Dolphin Control button

9cd042a86c removed the text from the Control button without setting an
accessibleName property, which is a regression for screen-reader users.

This breaks the 19.12 string freeze, but since it's the same string we
were translating before 9cd042a86c, hopefully it's not going to be too
much of a burden for translators.

CCBUG: 414271
CCMAIL: kde-i18n-doc@kde.org
---

diff --git a/src/dolphinmainwindow.cpp b/src/dolphinmainwindow.cpp
index e28b18cd3..56ea93e10 100644
--- a/src/dolphinmainwindow.cpp
+++ b/src/dolphinmainwindow.cpp
@@ -1880,6 +1880,7 @@ void DolphinMainWindow::createControlButton()
     Q_ASSERT(!m_controlButton);
 
     m_controlButton = new QToolButton(this);
+    m_controlButton->setAccessibleName(i18nc("@action:intoolbar", "Control"));
     m_controlButton->setIcon(QIcon::fromTheme(QStringLiteral("application-menu")));
     m_controlButton->setToolTip(i18nc("@action", "Show menu"));
     m_controlButton->setAttribute(Qt::WidgetAttribute::WA_CustomWhatsThis);