From: Frank Reininghaus <frank78ac@googlemail.com>
Date: Thu, 30 Apr 2009 09:04:49 +0000 (+0000)
Subject: Do not emit DolphinView's urlChanged(const KUrl&) signal if the view
X-Git-Url: https://cloud.milkyroute.net/gitweb/dolphin.git/commitdiff_plain/8a68bc8e184a02528827e0d56a372ef925c766b4

Do not emit DolphinView's urlChanged(const KUrl&) signal if the view
is activated, as discussed with Peter. This fixes a crash on a failed
assert if the DolphinView's and the KUrlNavigator's URLs are slightly
different (i.e., if a slash has been added to the navigator's URL by
KDirLister).

I could not find any regressions caused by this change so far, but
even if there are side effects, the upcoming beta and RC releases
should give enough user feedback and time to fix them.

BUG: 180494

svn path=/trunk/KDE/kdebase/apps/; revision=961519
---

diff --git a/src/dolphinview.cpp b/src/dolphinview.cpp
index f2f23d273..48df3e20f 100644
--- a/src/dolphinview.cpp
+++ b/src/dolphinview.cpp
@@ -187,10 +187,6 @@ void DolphinView::setActive(bool active)
 
     QColor color = KColorScheme(QPalette::Active, KColorScheme::View).background().color();
     if (active) {
-        // TODO: emitting urlChanged() is a hack, as the URL hasn't really changed. It
-        // bypasses the problem when having a split view and changing the active view to
-        // update the some URL dependent states. A nicer approach should be no big deal...
-        emit urlChanged(url());
         emit selectionChanged(selectedItems());
     } else {
         color.setAlpha(150);