From: Alexander Miller <alex.miller@gmx.de>
Date: Fri, 18 May 2018 20:44:52 +0000 (+0200)
Subject: Make target_link_libraries for kdeinit_dolphin PRIVATE
X-Git-Url: https://cloud.milkyroute.net/gitweb/dolphin.git/commitdiff_plain/8e6f4eecd318041d2e4e6386d1660742dd4ddd89

Make target_link_libraries for kdeinit_dolphin PRIVATE

Summary:
There is no need to add all of kdeinit_dolphin's
dependencies (including the static archive) when
linking dolphin; kdemain is the only needed symbol.
Mark the link libraries PRIVATE to simplify the
link command for dolphin.

Reviewers: #dolphin, elvisangelaccio

Reviewed By: elvisangelaccio

Subscribers: asturmlechner, kfm-devel

Tags: #dolphin

Differential Revision: https://phabricator.kde.org/D12931
---

diff --git a/src/CMakeLists.txt b/src/CMakeLists.txt
index e8fe719a4..beaa0ec50 100644
--- a/src/CMakeLists.txt
+++ b/src/CMakeLists.txt
@@ -299,7 +299,7 @@ ecm_add_app_icon(dolphin_SRCS ICONS ${ICONS_SRCS})
 kf5_add_kdeinit_executable(dolphin ${dolphin_SRCS})
 
 
-target_link_libraries(kdeinit_dolphin
+target_link_libraries(kdeinit_dolphin PRIVATE
     dolphinstatic
     dolphinprivate
 )