From: Méven Car <meven29@gmail.com>
Date: Tue, 5 May 2020 05:31:54 +0000 (+0200)
Subject: Sort by file size according to DetailsModeSettings::directorySizeCount
X-Git-Url: https://cloud.milkyroute.net/gitweb/dolphin.git/commitdiff_plain/91ea1e29eebda1f9a12c5a09b9df140353f48242?hp=31f5dc7f7c34eaab8570d84868e1564d0688b331

Sort by file size according to DetailsModeSettings::directorySizeCount

Test Plan: Sort by file size in details view.

Reviewers: #dolphin, ngraham, elvisangelaccio

Reviewed By: #dolphin, ngraham

Subscribers: kfm-devel

Tags: #dolphin

Differential Revision: https://phabricator.kde.org/D29424
---

diff --git a/src/kitemviews/kfileitemmodel.cpp b/src/kitemviews/kfileitemmodel.cpp
index 5e9603ba1..ac3c33e22 100644
--- a/src/kitemviews/kfileitemmodel.cpp
+++ b/src/kitemviews/kfileitemmodel.cpp
@@ -1770,12 +1770,12 @@ int KFileItemModel::sortRoleCompare(const ItemData* a, const ItemData* b, const
 
             QVariant valueA, valueB;
             if (DetailsModeSettings::directorySizeCount()) {
+                valueA = a->values.value("count");
+                valueB = b->values.value("count");
+            } else {
                 // use dir size then
                 valueA = a->values.value("size");
                 valueB = b->values.value("size");
-            } else {
-                valueA = a->values.value("count");
-                valueB = b->values.value("count");
             }
             if (valueA.isNull() && valueB.isNull()) {
                 result = 0;