From: Nicolas Fella <nicolas.fella@gmx.de>
Date: Fri, 8 Mar 2024 17:46:32 +0000 (+0100)
Subject: Remove unneeded code for toggeling dockwidget visibility
X-Git-Url: https://cloud.milkyroute.net/gitweb/dolphin.git/commitdiff_plain/95551f44922670be5c4d670833c2d4e398657495?ds=sidebyside

Remove unneeded code for toggeling dockwidget visibility

QDockWidget::toggleViewAction::toggled is emitted when minimizing
the application window on X11 (https://bugreports.qt.io/browse/QTBUG-48161
potentially related). This will cause the dockwidget to be hidden when
minimizing the window.

We don't actually seem to need that connection, triggering the action
(via shortcut or menu) seems to correctly show/hide the dockwidget
without it

BUG: 481952
---

diff --git a/src/dolphinmainwindow.cpp b/src/dolphinmainwindow.cpp
index 03486a9cf..1f4de8869 100644
--- a/src/dolphinmainwindow.cpp
+++ b/src/dolphinmainwindow.cpp
@@ -2619,8 +2619,6 @@ void DolphinMainWindow::createPanelAction(const QIcon &icon, const QKeySequence
 
     QAction *panelAction = actionCollection()->addAction(actionName, dockAction);
     actionCollection()->setDefaultShortcut(panelAction, shortcut);
-
-    connect(panelAction, &QAction::toggled, dockWidget, &QWidget::setVisible);
 }
 // clang-format off
 void DolphinMainWindow::setupWhatsThis()