From: Méven Car <meven@kde.org>
Date: Sat, 30 Mar 2024 12:20:11 +0000 (+0100)
Subject: kitemlist: don't open dir when double-click on expand arrow
X-Git-Url: https://cloud.milkyroute.net/gitweb/dolphin.git/commitdiff_plain/95e88ff1fcfa475b47ad9274ef65a12e49b20f20?ds=sidebyside

kitemlist: don't open dir when double-click on expand arrow

BUG: 484688
---

diff --git a/src/kitemviews/kitemlistcontroller.cpp b/src/kitemviews/kitemlistcontroller.cpp
index 71c37a7af..3ab20640c 100644
--- a/src/kitemviews/kitemlistcontroller.cpp
+++ b/src/kitemviews/kitemlistcontroller.cpp
@@ -712,8 +712,11 @@ bool KItemListController::mouseDoubleClickEvent(QGraphicsSceneMouseEvent *event,
         return false;
     }
 
-    bool emitItemActivated = !(m_view->style()->styleHint(QStyle::SH_ItemView_ActivateItemOnSingleClick) || m_singleClickActivationEnforced)
-        && (event->button() & Qt::LeftButton) && index.has_value() && index.value() < m_model->count();
+    if (m_view->style()->styleHint(QStyle::SH_ItemView_ActivateItemOnSingleClick) || m_singleClickActivationEnforced) {
+        return false;
+    }
+
+    const bool emitItemActivated = index.has_value() && index.value() < m_model->count() && !m_view->isAboveExpansionToggle(index.value(), pos);
     if (emitItemActivated) {
         Q_EMIT itemActivated(index.value());
     }