From: Peter Penz <peter.penz19@gmail.com>
Date: Sat, 19 Feb 2011 17:47:48 +0000 (+0100)
Subject: Use the new KIO::PreviewJob API
X-Git-Url: https://cloud.milkyroute.net/gitweb/dolphin.git/commitdiff_plain/96c0153e96917e994b5a188a01bb021fc4832707?ds=sidebyside

Use the new KIO::PreviewJob API

This makes it unnecessary to manually apply the plugins. See https://git.reviewboard.kde.org/r/100578/ for more details.
---

diff --git a/src/panels/information/informationpanelcontent.cpp b/src/panels/information/informationpanelcontent.cpp
index 69951f22c..77a623238 100644
--- a/src/panels/information/informationpanelcontent.cpp
+++ b/src/panels/information/informationpanelcontent.cpp
@@ -63,8 +63,7 @@ InformationPanelContent::InformationPanelContent(QWidget* parent) :
     m_phononWidget(0),
     m_nameLabel(0),
     m_metaDataWidget(0),
-    m_metaDataArea(0),
-    m_enabledPlugins()
+    m_metaDataArea(0)
 {
     parent->installEventFilter(this);
 
@@ -174,16 +173,8 @@ void InformationPanelContent::showItem(const KFileItem& item)
                 m_outdatedPreviewTimer->start();
             }
 
-            if (m_enabledPlugins.isEmpty()) {
-                const KConfigGroup globalConfig(KGlobal::config(), "PreviewSettings");
-                m_enabledPlugins = globalConfig.readEntry("Plugins", QStringList()
-                                                                     << "directorythumbnail"
-                                                                     << "imagethumbnail"
-                                                                     << "jpegthumbnail");
-            }
-
-            KIO::PreviewJob* job = KIO::filePreview(KFileItemList() << item, m_preview->width(), m_preview->height(),
-                                                    0, 0, false, true, &m_enabledPlugins);
+            KIO::PreviewJob* job = KIO::filePreview(KFileItemList() << item, QSize(m_preview->width(), m_preview->height()));
+            job->setScaleType(KIO::PreviewJob::Unscaled);
 
             connect(job, SIGNAL(gotPreview(const KFileItem&, const QPixmap&)),
                     this, SLOT(showPreview(const KFileItem&, const QPixmap&)));
diff --git a/src/panels/information/informationpanelcontent.h b/src/panels/information/informationpanelcontent.h
index 184ce557d..1d964f515 100644
--- a/src/panels/information/informationpanelcontent.h
+++ b/src/panels/information/informationpanelcontent.h
@@ -135,7 +135,6 @@ private:
     QLabel* m_nameLabel;
     KFileMetaDataWidget* m_metaDataWidget;
     QScrollArea* m_metaDataArea;
-    QStringList m_enabledPlugins;
 };
 
 #endif // INFORMATIONPANELCONTENT_H
diff --git a/src/views/tooltips/tooltipmanager.cpp b/src/views/tooltips/tooltipmanager.cpp
index cb86b3355..44e60049f 100644
--- a/src/views/tooltips/tooltipmanager.cpp
+++ b/src/views/tooltips/tooltipmanager.cpp
@@ -20,7 +20,6 @@
 #include "tooltipmanager.h"
 
 #include "filemetadatatooltip.h"
-#include <KConfigGroup>
 #include <KIcon>
 #include <KIO/PreviewJob>
 #include <KSharedConfig>
@@ -47,8 +46,7 @@ ToolTipManager::ToolTipManager(QAbstractItemView* parent,
     m_metaDataRequested(false),
     m_appliedWaitCursor(false),
     m_item(),
-    m_itemRect(),
-    m_enabledPlugins()
+    m_itemRect()
 {
     static FileMetaDataToolTip* sharedToolTip = 0;
     if (!sharedToolTip) {
@@ -171,14 +169,7 @@ void ToolTipManager::startContentRetrieval()
     // Request a preview of the item
     m_fileMetaDataToolTip->setPreview(QPixmap());
 
-    if (m_enabledPlugins.isEmpty()) {
-        const KConfigGroup globalConfig(KGlobal::config(), "PreviewSettings");
-        m_enabledPlugins = globalConfig.readEntry("Plugins", QStringList()
-                                                             << "directorythumbnail"
-                                                             << "imagethumbnail"
-                                                             << "jpegthumbnail");
-    }
-    KIO::PreviewJob* job = KIO::filePreview(KFileItemList() << m_item, 256, 256, true, true, &m_enabledPlugins);
+    KIO::PreviewJob* job = KIO::filePreview(KFileItemList() << m_item, QSize(256, 256));
 
     connect(job, SIGNAL(gotPreview(const KFileItem&, const QPixmap&)),
             this, SLOT(setPreviewPix(const KFileItem&, const QPixmap&)));
diff --git a/src/views/tooltips/tooltipmanager.h b/src/views/tooltips/tooltipmanager.h
index 2dee9d286..f8bcd3dfd 100644
--- a/src/views/tooltips/tooltipmanager.h
+++ b/src/views/tooltips/tooltipmanager.h
@@ -87,7 +87,6 @@ private:
     bool m_appliedWaitCursor;
     KFileItem m_item;
     QRect m_itemRect;
-    QStringList m_enabledPlugins;
 };
 
 #endif