From: Jackson Reed McNeill <jacksonmcneill01@gmail.com>
Date: Wed, 17 Jul 2019 19:35:51 +0000 (+0200)
Subject: Fix rubber band not going away after right-click
X-Git-Url: https://cloud.milkyroute.net/gitweb/dolphin.git/commitdiff_plain/aabfce16797a321094c7a30c96c11a1a7ae01a9f?ds=inline

Fix rubber band not going away after right-click

Summary: Fix rubber band not going away after right-click in the folder view

Test Plan:
Hold left click
Drag to make rubber band
Right click

Reviewers: #dolphin, ngraham, elvisangelaccio

Reviewed By: #dolphin, ngraham

Subscribers: elvisangelaccio, ngraham, kfm-devel

Tags: #dolphin

Differential Revision: https://phabricator.kde.org/D21590
---

diff --git a/src/kitemviews/kitemlistcontroller.cpp b/src/kitemviews/kitemlistcontroller.cpp
index 4bfd5b4cb..82553ddda 100644
--- a/src/kitemviews/kitemlistcontroller.cpp
+++ b/src/kitemviews/kitemlistcontroller.cpp
@@ -596,6 +596,16 @@ bool KItemListController::mousePressEvent(QGraphicsSceneMouseEvent* event, const
         m_selectionManager->endAnchoredSelection();
     }
 
+    if (event->buttons() & Qt::RightButton) {
+        // Stop rubber band from persisting after right-clicks
+        KItemListRubberBand* rubberBand = m_view->rubberBand();
+        if (rubberBand->isActive()) {
+            disconnect(rubberBand, &KItemListRubberBand::endPositionChanged, this, &KItemListController::slotRubberBandChanged);
+            rubberBand->setActive(false);
+            m_view->setAutoScroll(false);
+        }
+    }
+
     if (m_pressedIndex >= 0) {
         m_selectionManager->setCurrentItem(m_pressedIndex);