From: Ismael Asensio <isma.af@gmail.com>
Date: Wed, 13 Nov 2019 21:48:45 +0000 (+0100)
Subject: fix(search): Allow to set empty type
X-Git-Url: https://cloud.milkyroute.net/gitweb/dolphin.git/commitdiff_plain/adfc098aa74723ec3f01cda513290864ef9ee0f9

fix(search): Allow to set empty type

Summary:
This small patch allows to set and empty `type` to the extended options, which will set the `Any Type` option (index 0).
It doesn't make any change in current code, since this case is not called, but it helps simplifying follow-up patches.

Test Plan:
No behavior changes with current code.
Calling `setFacetsType(QString())` actually sets the first option (`Any Type`)

Reviewers: elvisangelaccio, #dolphin

Reviewed By: elvisangelaccio, #dolphin

Subscribers: kfm-devel

Tags: #dolphin

Differential Revision: https://phabricator.kde.org/D25255
---

diff --git a/src/search/dolphinfacetswidget.cpp b/src/search/dolphinfacetswidget.cpp
index 182719225..ae05509e7 100644
--- a/src/search/dolphinfacetswidget.cpp
+++ b/src/search/dolphinfacetswidget.cpp
@@ -153,7 +153,7 @@ void DolphinFacetsWidget::setRatingTerm(const QString& term)
 
 void DolphinFacetsWidget::setFacetType(const QString& type)
 {
-    for (int index = 1; index <= m_typeSelector->count(); index++) {
+    for (int index = 0; index <= m_typeSelector->count(); index++) {
         if (type == m_typeSelector->itemData(index).toString()) {
             m_typeSelector->setCurrentIndex(index);
             break;