From: Peter Penz <peter.penz19@gmail.com>
Date: Fri, 11 May 2012 14:23:49 +0000 (+0200)
Subject: Allow moving items to trash also for non-local files
X-Git-Url: https://cloud.milkyroute.net/gitweb/dolphin.git/commitdiff_plain/b319c59b8d1e068cf621be852ced9c5396bd77f9?ds=inline

Allow moving items to trash also for non-local files

See bug 188032 for an ongoing discussion. In case if this behavior
is really not wanted by users (the feedback on bugs.kde.org will
show), the review-request
https://git.reviewboard.kde.org/r/104915/ should be merged too
(after adjusting some parts of the code).
---

diff --git a/src/dolphincontextmenu.cpp b/src/dolphincontextmenu.cpp
index 286d304c5..670062250 100644
--- a/src/dolphincontextmenu.cpp
+++ b/src/dolphincontextmenu.cpp
@@ -559,7 +559,7 @@ void DolphinContextMenu::updateRemoveAction()
 
 bool DolphinContextMenu::moveToTrash() const
 {
-    return selectedItemsProperties().isLocal() && !m_shiftPressed;
+    return !m_shiftPressed;
 }
 
 #include "dolphincontextmenu.moc"
diff --git a/src/dolphincontextmenu.h b/src/dolphincontextmenu.h
index 9e8b804cd..75a6e35e8 100644
--- a/src/dolphincontextmenu.h
+++ b/src/dolphincontextmenu.h
@@ -176,8 +176,8 @@ private:
     void updateRemoveAction();
 
     /**
-     * @return True if no shift key has been pressed and the selection represents
-     *         only local files.
+     * @return True if a moving to the trash should be done instead of
+     *         deleting the selected items.
      * @see updateRemoveAction(), slotRemoveActionTriggered()
      */
     bool moveToTrash() const;