From: Nate Graham <nate@kde.org>
Date: Tue, 13 Oct 2020 00:16:53 +0000 (-0600)
Subject: Show "Open With" menu items even for empty dirs
X-Git-Url: https://cloud.milkyroute.net/gitweb/dolphin.git/commitdiff_plain/b343fdffc52ff42d83afa02f6eaf1f5a359a49a9?ds=inline

Show "Open With" menu items even for empty dirs

We found some legitimate use cases for this after all! :)

This reverts 14f0cd52f61de7539e2d9c751966594708ed0281

BUG: 427573
FIXED-IN: 5.12
---

diff --git a/src/dolphincontextmenu.cpp b/src/dolphincontextmenu.cpp
index d4807d3a7..f091039a7 100644
--- a/src/dolphincontextmenu.cpp
+++ b/src/dolphincontextmenu.cpp
@@ -335,11 +335,9 @@ void DolphinContextMenu::openViewportContextMenu()
     newFileMenu->setPopupFiles(QList<QUrl>() << m_baseUrl);
     addMenu(newFileMenu->menu());
 
-    // Don't show "Open With" menu items if the current dir is empty, because there's
-    // generally no app that can do anything interesting with an empty directory
-    if (view->itemsCount() != 0) {
-        addOpenWithActions(fileItemActions);
-    }
+    // Show "open with" menu items even if the dir is empty, because there are legitimate
+    // use cases for this, such as opening an empty dir in Kate or VSCode or something
+    addOpenWithActions(fileItemActions);
 
     QAction* pasteAction = createPasteAction();
     addAction(pasteAction);