From: Frank Reininghaus <frank78ac@googlemail.com>
Date: Sun, 9 Nov 2014 17:08:29 +0000 (+0100)
Subject: Use deleteLater() to delete the selection toggle in KItemListWidget
X-Git-Url: https://cloud.milkyroute.net/gitweb/dolphin.git/commitdiff_plain/b73ed8eba98f8a038e10c8f5f3ef6b2e432e01c1

Use deleteLater() to delete the selection toggle in KItemListWidget

This patch should make a crash with a backtrace as provided in the bug
report impossible. I'm not sure if this would really prevent the crash
- it looks like the actual cause of the problem could be in
QGraphicsView or anywhere else, but it's hard to tell because the bug
was reported just once and does not seem reproducible. But I'm pretty
sure that this change doesn't make anything worse.

BUG: 334785
REVIEW: 121087
---

diff --git a/src/kitemviews/kitemlistwidget.cpp b/src/kitemviews/kitemlistwidget.cpp
index e7d2951b9..46b75588f 100644
--- a/src/kitemviews/kitemlistwidget.cpp
+++ b/src/kitemviews/kitemlistwidget.cpp
@@ -474,7 +474,7 @@ qreal KItemListWidget::hoverOpacity() const
 void KItemListWidget::slotHoverAnimationFinished()
 {
     if (!m_hovered) {
-        delete m_selectionToggle;
+        m_selectionToggle->deleteLater();
         m_selectionToggle = 0;
     }
 }