From: Frank Reininghaus <frank78ac@googlemail.com>
Date: Sun, 4 Aug 2013 19:46:08 +0000 (+0200)
Subject: Fix possible out of range error inKItemListSizeHintResolver::itemsMoved
X-Git-Url: https://cloud.milkyroute.net/gitweb/dolphin.git/commitdiff_plain/bedf1db916ae80a3c27062cbd86f476d166fd51c?ds=inline

Fix possible out of range error inKItemListSizeHintResolver::itemsMoved

The function assumes implicitly that the moved range always starts with
the index 0. This is indeed the case at the moment, but it might make
sense to change that in the future. This commit prevents that we get an
out of range problem then.

Thanks to Emmanuel Pescosta for finding this problem, see
https://git.reviewboard.kde.org/r/111808/
---

diff --git a/src/kitemviews/private/kitemlistsizehintresolver.cpp b/src/kitemviews/private/kitemlistsizehintresolver.cpp
index e44630243..c86ce2bf8 100644
--- a/src/kitemviews/private/kitemlistsizehintresolver.cpp
+++ b/src/kitemviews/private/kitemlistsizehintresolver.cpp
@@ -120,7 +120,7 @@ void KItemListSizeHintResolver::itemsMoved(const KItemRange& range, const QList<
 
     const int movedRangeEnd = range.index + range.count;
     for (int i = range.index; i < movedRangeEnd; ++i) {
-        const int newIndex = movedToIndexes.at(i);
+        const int newIndex = movedToIndexes.at(i - range.index);
         newSizeHintCache[newIndex] = m_sizeHintCache.at(i);
     }