From: Méven Car <meven29@gmail.com>
Date: Sun, 17 Mar 2019 20:21:33 +0000 (+0100)
Subject: When the previewed video stops playing (because of the user or because the media... 
X-Git-Url: https://cloud.milkyroute.net/gitweb/dolphin.git/commitdiff_plain/bf314f2dff99ad972a424564499e4d988588a173?ds=inline

When the previewed video stops playing (because of the user or because the media playback has ended), show the regular preview only if the preview setting is on.

Summary:
Bug result after test plan :

{F6698812}

Test Plan:
In dolphin with the information panel
Select a video
Play the video
Disable the preview through the context menu (the video stays playing and visible and this will get fixed in a subsequent review)
Stop the video -> the video preview reappears when it should not

Reviewers: elvisangelaccio

Reviewed By: elvisangelaccio

Subscribers: elvisangelaccio, kfm-devel

Tags: #dolphin

Differential Revision: https://phabricator.kde.org/D19843
---

diff --git a/src/panels/information/informationpanelcontent.cpp b/src/panels/information/informationpanelcontent.cpp
index 7704bdf16..4b34e55e3 100644
--- a/src/panels/information/informationpanelcontent.cpp
+++ b/src/panels/information/informationpanelcontent.cpp
@@ -300,7 +300,7 @@ KFileItemList InformationPanelContent::items() {
 
 void InformationPanelContent::slotHasVideoChanged(bool hasVideo)
 {
-    m_preview->setVisible(!hasVideo);
+    m_preview->setVisible(InformationPanelSettings::previewsShown() && !hasVideo);
 }
 
 void InformationPanelContent::refreshMetaData()