From: Simon Depiets <sdepiets@gmail.com>
Date: Wed, 6 Mar 2019 00:15:43 +0000 (+0800)
Subject: Improve wording of split view/pane settings
X-Git-Url: https://cloud.milkyroute.net/gitweb/dolphin.git/commitdiff_plain/c148eff8ca34292acd046fcdbc105e3d1a24b489

Improve wording of split view/pane settings

Summary:
I found these strings very hard to understand then translate without looking into the code because the use of "view" refers to both "the split view" and "the left pane and the right pane of the split view".

This patch attempts to explicitly mention panes when needed.

Reviewers: #dolphin, angeloevertonjr, ngraham

Reviewed By: #dolphin, ngraham

Subscribers: ngraham, kfm-devel

Tags: #dolphin

Differential Revision: https://phabricator.kde.org/D19579
---

diff --git a/src/settings/dolphin_generalsettings.kcfg b/src/settings/dolphin_generalsettings.kcfg
index e76103c5e..62c171846 100644
--- a/src/settings/dolphin_generalsettings.kcfg
+++ b/src/settings/dolphin_generalsettings.kcfg
@@ -75,7 +75,7 @@
             <default>false</default>
         </entry>
         <entry name="CloseActiveSplitView" type="Bool">
-            <label>Close active view when toggling off</label>
+            <label>Close active pane when toggling off split view</label>
             <default>true</default>
         </entry>
         <entry name="ShowToolTips" type="Bool">
diff --git a/src/settings/general/behaviorsettingspage.cpp b/src/settings/general/behaviorsettingspage.cpp
index 0b5cee7aa..0747891b3 100644
--- a/src/settings/general/behaviorsettingspage.cpp
+++ b/src/settings/general/behaviorsettingspage.cpp
@@ -96,11 +96,11 @@ BehaviorSettingsPage::BehaviorSettingsPage(const QUrl& url, QWidget* parent) :
     m_renameInline = new QCheckBox(i18nc("option:check", "Rename inline"));
     topLayout->addRow(QString(), m_renameInline);
 
-    // 'Switch between split views with tab key'
-    m_useTabForSplitViewSwitch = new QCheckBox(i18nc("option:check", "Switch between split views with tab key"));
+    // 'Switch between panes of split views with tab key'
+    m_useTabForSplitViewSwitch = new QCheckBox(i18nc("option:check", "Switch between split views panes with tab key"));
     topLayout->addRow(QString(), m_useTabForSplitViewSwitch);
 
-    // 'Close active view when turning off split view'
+    // 'Close active pane when turning off split view'
     m_closeActiveSplitView = new QCheckBox(i18nc("option:check", "Turning off split view closes active pane"));
     topLayout->addRow(QString(), m_closeActiveSplitView);
     m_closeActiveSplitView->setToolTip(i18n("When deactivated, turning off split view will close the inactive pane"));