From: Emmanuel Pescosta <emmanuelpescosta099@gmail.com>
Date: Mon, 17 Dec 2012 13:02:22 +0000 (+0100)
Subject: Fix Bug 287829 - inline rename multiple files does not honour
X-Git-Url: https://cloud.milkyroute.net/gitweb/dolphin.git/commitdiff_plain/c304ca1bb0eb1e56716d6b828bab2fc6160206dc?ds=inline

Fix Bug 287829 - inline rename multiple files does not honour
 sort order

BUG: 287829
FIXED-IN: 4.9.5
REVIEW: 107718
---

diff --git a/src/views/dolphinview.cpp b/src/views/dolphinview.cpp
index 0e97c5a2b..cca5846b6 100644
--- a/src/views/dolphinview.cpp
+++ b/src/views/dolphinview.cpp
@@ -342,10 +342,12 @@ int DolphinView::itemsCount() const
 KFileItemList DolphinView::selectedItems() const
 {
     const KItemListSelectionManager* selectionManager = m_container->controller()->selectionManager();
-    const QSet<int> selectedIndexes = selectionManager->selectedItems();
+    QList<int> selectedIndexes = selectionManager->selectedItems().toList();
+
+    qSort(selectedIndexes);
 
     KFileItemList selectedItems;
-    QSetIterator<int> it(selectedIndexes);
+    QListIterator<int> it(selectedIndexes);
     while (it.hasNext()) {
         const int index = it.next();
         selectedItems.append(m_model->fileItem(index));
diff --git a/src/views/renamedialog.cpp b/src/views/renamedialog.cpp
index a91f91b1b..65125c3aa 100644
--- a/src/views/renamedialog.cpp
+++ b/src/views/renamedialog.cpp
@@ -162,11 +162,6 @@ void RenameDialog::slotTextChanged(const QString& newName)
 
 void RenameDialog::renameItems()
 {
-    // Currently the items are sorted by the selection order, resort
-    // them by the filename. This assures that the new sort order is similar to
-    // the current filename sort order.
-    qSort(m_items.begin(), m_items.end(), lessThan);
-
     // Iterate through all items and rename them...
     int index = m_spinBox->value();
     foreach (const KFileItem& item, m_items) {