From: Friedrich W. H. Kossebau <kossebau@kde.org>
Date: Sun, 3 Jul 2022 16:59:27 +0000 (+0200)
Subject: Open >5 terminals dialog: use action terms instead of Yes/No buttons
X-Git-Url: https://cloud.milkyroute.net/gitweb/dolphin.git/commitdiff_plain/c6f82aa378a58feaff5ad015057831e5bc535f0e?ds=inline

Open >5 terminals dialog: use action terms instead of Yes/No buttons

Yes/No buttons in dialogs are discouraged (not only) by KDE HIG in favour
of actions terms.
---

diff --git a/src/dolphinmainwindow.cpp b/src/dolphinmainwindow.cpp
index 24da84132..65c99329b 100644
--- a/src/dolphinmainwindow.cpp
+++ b/src/dolphinmainwindow.cpp
@@ -1119,7 +1119,10 @@ void DolphinMainWindow::openTerminalHere()
     if (urls.count() > 5) {
         QString question = i18np("Are you sure you want to open 1 terminal window?",
                                  "Are you sure you want to open %1 terminal windows?", urls.count());
-        const int answer = KMessageBox::warningYesNo(this, question);
+        const int answer = KMessageBox::warningYesNo(this, question, {},
+                                                     KGuiItem(i18ncp("@action:button", "Open %1 Terminal", "Open %1 Terminals", urls.count()),
+                                                              QStringLiteral("utilities-terminal")),
+                                                     KStandardGuiItem::cancel());
         if (answer != KMessageBox::Yes) {
             return;
         }