From: Eduardo Robles Elvira <edulix@gmail.com>
Date: Thu, 21 Feb 2008 09:55:08 +0000 (+0000)
Subject: Bugfix: Currently, if you open dolphin, select a bunch of files, and right click and
X-Git-Url: https://cloud.milkyroute.net/gitweb/dolphin.git/commitdiff_plain/c73591380173b52504aaceb74314f617b2e04f6c

Bugfix: Currently, if you open dolphin, select a bunch of files, and right click and
select Open With > whatever, all the files are opened. Which is the right
thing. However, if you hit enter to open those selected files, no file is
opened. Currently, the file is only opened if there's only *one* file
selected. The attached patch fixes this problem.


svn path=/trunk/KDE/kdebase/apps/; revision=777695
---

diff --git a/src/dolphincolumnwidget.cpp b/src/dolphincolumnwidget.cpp
index 5f5f761dc..f8db0e865 100644
--- a/src/dolphincolumnwidget.cpp
+++ b/src/dolphincolumnwidget.cpp
@@ -349,9 +349,15 @@ void DolphinColumnWidget::keyPressEvent(QKeyEvent* event)
     const QModelIndex currentIndex = selModel->currentIndex();
     const bool trigger = currentIndex.isValid()
                          && (event->key() == Qt::Key_Return)
-                         && (selModel->selectedIndexes().count() <= 1);
-    if (trigger) {
-        triggerItem(currentIndex);
+                         && (selModel->selectedIndexes().count() > 0);
+    if(trigger) {
+        const QModelIndexList indexList = selModel->selectedIndexes();
+        foreach (const QModelIndex &index, indexList) {
+            KFileItem item = itemForIndex(index);
+            if (!item.isNull()) {
+                triggerItem(index);
+            }
+        }
     }
 }
 
diff --git a/src/dolphindetailsview.cpp b/src/dolphindetailsview.cpp
index 75481fb36..3f23795ba 100644
--- a/src/dolphindetailsview.cpp
+++ b/src/dolphindetailsview.cpp
@@ -377,9 +377,15 @@ void DolphinDetailsView::keyPressEvent(QKeyEvent* event)
     const QModelIndex currentIndex = selModel->currentIndex();
     const bool trigger = currentIndex.isValid()
                          && (event->key() == Qt::Key_Return)
-                         && (selModel->selectedIndexes().count() <= 1);
-    if (trigger) {
-        triggerItem(currentIndex);
+                         && (selModel->selectedIndexes().count() > 0);
+    if(trigger) {
+        const QModelIndexList indexList = selModel->selectedIndexes();
+        foreach (const QModelIndex &index, indexList) {
+            KFileItem item = itemForIndex(index);
+            if (!item.isNull()) {
+                triggerItem(index);
+            }
+        }
     }
 }
 
diff --git a/src/dolphiniconsview.cpp b/src/dolphiniconsview.cpp
index 96f69436d..b1ffd401c 100644
--- a/src/dolphiniconsview.cpp
+++ b/src/dolphiniconsview.cpp
@@ -297,9 +297,15 @@ void DolphinIconsView::keyPressEvent(QKeyEvent* event)
     const QModelIndex currentIndex = selModel->currentIndex();
     const bool trigger = currentIndex.isValid()
                          && (event->key() == Qt::Key_Return)
-                         && (selModel->selectedIndexes().count() <= 1);
-    if (trigger) {
-        triggerItem(currentIndex);
+                         && (selModel->selectedIndexes().count() > 0);
+    if(trigger) {
+        const QModelIndexList indexList = selModel->selectedIndexes();
+        foreach (const QModelIndex &index, indexList) {
+            KFileItem item = itemForIndex(index);
+            if (!item.isNull()) {
+                triggerItem(index);
+            }
+        }
     }
 }