From: Elvis Angelaccio <elvis.angelaccio@kde.org>
Date: Sat, 13 Oct 2018 09:15:09 +0000 (+0200)
Subject: [PlacesItemModelTest] Try to double test timeout
X-Git-Url: https://cloud.milkyroute.net/gitweb/dolphin.git/commitdiff_plain/c9dd3478be21bc8a4bbd6102b1d66997df180d5f?ds=inline

[PlacesItemModelTest] Try to double test timeout

The randomly failing `testRefresh()` on the CI can be reproduced by
replacing the QTRY_COMPARE with a simple QCOMPARE.

So it seems the CI can be slow such that the default QTR_COMPARE
timeout of 5 seconds is not enough.

If a timeout of 10 seconds fixes this particular test case, we can use
this bigger timeout also in the other failing tests.
---

diff --git a/src/tests/placesitemmodeltest.cpp b/src/tests/placesitemmodeltest.cpp
index 40ee47cbc..c05ce6882 100644
--- a/src/tests/placesitemmodeltest.cpp
+++ b/src/tests/placesitemmodeltest.cpp
@@ -43,6 +43,11 @@ Q_DECLARE_METATYPE(KItemRange)
 #define KDE_ROOT_PATH "/"
 #endif
 
+namespace
+{
+    constexpr int TIMEOUT = 10000;
+}
+
 static QString bookmarksFile()
 {
     return QStandardPaths::writableLocation(QStandardPaths::GenericDataLocation) + "/user-places.xbel";
@@ -738,7 +743,7 @@ void PlacesItemModelTest::testRefresh()
     m_model->refresh();
 
     // item must be equal
-    QTRY_COMPARE(item->text(), sameItem->text());
+    QTRY_COMPARE_WITH_TIMEOUT(item->text(), sameItem->text(), TIMEOUT);
 }
 
 void PlacesItemModelTest::testIcons_data()